On Tue, 23 Jun 2009, Serge E. Hallyn wrote: > > (it keeps bugging me that the order of args to list_add() gets reversed > as a result, but clearly with both starting out empty it doesn't > matter..) .. and the new one is more logical. "list_add()" really adds the first entry to the list pointed to by the second one. It _works_ the other way too in this case, as you point out, but now that you mention it, it really looks like the pre-patch code is "wrong". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html