On Thu 10-08-23 09:12:04, Jeff Layton wrote: > commit 6bb885ecd746 (fat: add functions to update and truncate > timestamps appropriately") added an update_time routine for fat. That > patch added a section for handling the S_VERSION bit, even though FAT > doesn't enable SB_I_VERSION and the S_VERSION bit will never be set when > calling it. > > Remove the section for handling S_VERSION since it's effectively dead > code, and will be problematic vs. future changes. > > Cc: Frank Sorenson <sorenson@xxxxxxxxxx> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/fat/misc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/fat/misc.c b/fs/fat/misc.c > index ab28173348fa..37f4afb346af 100644 > --- a/fs/fat/misc.c > +++ b/fs/fat/misc.c > @@ -354,9 +354,6 @@ int fat_update_time(struct inode *inode, int flags) > dirty_flags |= I_DIRTY_SYNC; > } > > - if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false)) > - dirty_flags |= I_DIRTY_SYNC; > - > __mark_inode_dirty(inode, dirty_flags); > return 0; > } > > -- > 2.41.0 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
