Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>
Subject: Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date: Wed, 9 Aug 2023 11:09:25 +0200
Cc: Alice Ryhl <aliceryhl@xxxxxxxxxx>, rust-for-linux@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Miguel Ojeda <ojeda@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Wedson Almeida Filho <wedsonaf@xxxxxxxxx>, Alex Gaynor <alex.gaynor@xxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Gary Guo <gary@xxxxxxxxxxx>, Björn Roy Baron <bjorn3_gh@xxxxxxxxxxxxxx>, Benno Lossin <benno.lossin@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, patches@xxxxxxxxxxxxxxx
In-reply-to: <CANiq72mHU7n2jTPFsO=tjfqucrbe2ABSUYPUG6ctEerh4J+U_g@mail.gmail.com>

On Wed, Aug 9, 2023 at 11:00 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> If you mean for the commit, then we should follow the kernel
> convention instead. Please see my reply to Alice above.

One extra note: if it is a external repository, then yes, I would
definitely recommend adding a `Link` because readers may not be able
to easily `git show` the hash. But if it is the kernel tree, then it
is not needed.

Cheers,
Miguel

Follow-Ups:
- Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
  - From: Martin Rodriguez Reboredo

References:
- [RFC PATCH v1 0/5] Various Rust bindings for files
  - From: Alice Ryhl
- [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
  - From: Alice Ryhl
- Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
  - From: Martin Rodriguez Reboredo
- Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
  - From: Miguel Ojeda

Prev by Date: Re: [PATCH] zonefs: fix synchronous direct writes to sequential files
Next by Date: Re: new_inode_pseudo vs locked inode->i_state = 0
Previous by thread: Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
Next by thread: Re: [RFC PATCH v1 5/5] rust: file: add `DeferredFdCloser`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]