On Thu, 03 Aug 2023 22:46:11 -0700, Hugh Dickins wrote: > Commit "shmem: fix quota lock nesting in huge hole handling" was not so > good: Smatch caught shmem_recalc_inode()'s shmem_inode_unacct_blocks() > descending into quota_send_warning(): where blocking GFP_NOFS is used, > yet shmem_recalc_inode() is called holding the shmem inode's info->lock. > > Yes, both __dquot_alloc_space() and __dquot_free_space() are commented > "This operation can block, but only after everything is updated" - when > calling flush_warnings() at the end - both its print_warning() and its > quota_send_warning() may block. > > [...] Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [1/1] shmem: move spinlock into shmem_recalc_inode() to fix quota support https://git.kernel.org/vfs/vfs/c/f384c361c99e
