Re: [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode

[Jiachen Zhang <zhangjiachen.jaycee@xxxxxxxxxxxxx>]

On 2023/8/1 16:06, Hao Xu wrote:
> From: Hao Xu <howeyxu@xxxxxxxxxxx>
>
> In direct_io_relax mode, there can be shared mmaped files and thus dirty
> pages in its page cache. Therefore those dirty pages should be written
> back to backend before direct io to avoid data loss.
>
> Signed-off-by: Hao Xu <howeyxu@xxxxxxxxxxx>
> ---
>   fs/fuse/file.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 60f64eafb231..0bcdf0aafeb7 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1485,6 +1485,13 @@ ssize_t fuse_direct_io(struct fuse_io_priv *io, struct iov_iter *iter,
>   	if (!ia)
>   		return -ENOMEM;
>   
> +	if (fopen_direct_io && fc->direct_io_relax) {
> +		res = filemap_write_and_wait_range(mapping, pos, pos + count - 1);
> +		if (res) {
> +			fuse_io_free(ia);
> +			return res;
> +		}
> +	}
>   	if (!cuse && fuse_range_is_writeback(inode, idx_from, idx_to)) {
>   		if (!write)
>   			inode_lock(inode);


Reviewed-by: Jiachen Zhang <zhangjiachen.jaycee@xxxxxxxxxxxxx>

Thanks,
Jiachen