On Wed 02-08-23 13:54:38, Christoph Hellwig wrote: > dquot_load_quota_sb is only used in dquot.c, so mark it static. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Thanks for the cleanups! I've merged both into my tree. Honza > --- > fs/quota/dquot.c | 5 ++--- > include/linux/quotaops.h | 2 -- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index e3e4f40476579c..a0c577ab2b7b26 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -2352,8 +2352,8 @@ static int vfs_setup_quota_inode(struct inode *inode, int type) > return 0; > } > > -int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > - unsigned int flags) > +static int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > + unsigned int flags) > { > struct quota_format_type *fmt = find_quota_format(format_id); > struct quota_info *dqopt = sb_dqopt(sb); > @@ -2429,7 +2429,6 @@ int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > > return error; > } > -EXPORT_SYMBOL(dquot_load_quota_sb); > > /* > * More powerful function for turning on quotas on given quota inode allowing > diff --git a/include/linux/quotaops.h b/include/linux/quotaops.h > index 11a4becff3a983..671fd306ccf01c 100644 > --- a/include/linux/quotaops.h > +++ b/include/linux/quotaops.h > @@ -95,8 +95,6 @@ int dquot_mark_dquot_dirty(struct dquot *dquot); > > int dquot_file_open(struct inode *inode, struct file *file); > > -int dquot_load_quota_sb(struct super_block *sb, int type, int format_id, > - unsigned int flags); > int dquot_load_quota_inode(struct inode *inode, int type, int format_id, > unsigned int flags); > int dquot_quota_on(struct super_block *sb, int type, int format_id, > -- > 2.39.2 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR