On Wed 02-08-23 19:01:55, Jan Kara wrote: > On Tue 01-08-23 15:09:01, Christian Brauner wrote: > > Split the steps to create a superblock into a tiny helper. This will > > make the next patch easier to follow. > > > > Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx> > > I agree with Christoph that the error handling in vfs_fsconfig_locked() is > confusing - in particular the fact that if you 'break' out of the switch > statement it causes the fs context to be marked as failed is probably handy > but too subtle to my taste. > > Also I think this patch does cause a behavioral change because before if we > bailed e.g. due to: > > if (fc->phase != FS_CONTEXT_CREATE_PARAMS) > > we returned -EBUSY but didn't set fc->phase = FS_CONTEXT_FAILED. After your > patch we 'break' on any error and thus fc->phase is set on any error... Ah, I can see you've already posted v2 where you addressed this problem. Sorry for the noise. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
