On Tue, Aug 01, 2023 at 05:31:00PM +0200, Christoph Hellwig wrote: > On Tue, Aug 01, 2023 at 03:09:00PM +0200, Christian Brauner wrote: > > The get_tree_single_reconf() helper isn't used anywhere. Remote it. > > Yeah, I've got pretty much the same patch hiding somewhere in one of > me trees.. > > > -static int vfs_get_super(struct fs_context *fc, bool reconf, > > - int (*test)(struct super_block *, struct fs_context *), > > - int (*fill_super)(struct super_block *sb, > > - struct fs_context *fc)) > > +static int vfs_get_super(struct fs_context *fc, > > + int (*test)(struct super_block *, struct fs_context *), > > + int (*fill_super)(struct super_block *sb, > > + struct fs_context *fc)) > > .a althought keeping the existing formatting here seems much more readable > to me. No idea why the odd align to brace formatting has picked up so > many fans recently given that it is horrible to read and causes tons > of churn when touching the protoptype or function name. I'm not doing that manually. I'm using clang-format for this so I don't have to care about stuff like this. Tbh, the fact that we don't simply have an authoritative code formatting tool in-kernel over 30 years later that we settle on - at least on a per subsystem basis - is funny and sad. I'm fine not touching the header.
