On Wed, Jul 26, 2023 at 06:21:23AM -0700, Christoph Hellwig wrote: > On Mon, Jul 24, 2023 at 10:45:53PM -0400, Kent Overstreet wrote: > > And yet, we've had a subtle bug introduced in that code that took quite > > awhile to be fixed - I'm not pro code duplication in general and I don't > > think this is a good place to start. > > I'm not sure arguing for adding a helper your can triviall implement > yourself really helps to streamline your upstreaming process. I gave you my engineering reasons, you're the one who's arguing. And to make everything perfectly clear: this is code that I originally wrote, and then you started changing without CCing me - your patch that deleted zero_fill_bio_iter() never should've gone in.
