Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 1 Aug 2023 09:51:29 +0200
Cc: linux-erofs@xxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20230801014737.28614-1-hsiangkao@linux.alibaba.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Aug 01, 2023 at 09:47:37AM +0800, Gao Xiang wrote:
> Previously, .kill_sb() will be called only after fill_super fails.
> It will be changed [1].
> 
> Besides, checking for s_magic in erofs_kill_sb() is unnecessary from
> any point of view.  Let's get rid of it now.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb
  - From: Christian Brauner
- [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
  - From: Gao Xiang

Prev by Date: Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Next by Date: [PATCH v4 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode
Previous by thread: Re: [PATCH] erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Next by thread: Re: [syzbot] [erofs?] [fat?] WARNING in erofs_kill_sb
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux