Re: [PATCH 17/21] ceph: nfs re-export support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sage Weil wrote:
I've done the same thing in a bunch of other places, too, the big offender being decode.h, where e.g.

		v = le64_to_cpu(*(__le64 *)*(p));	\
                *(p) += sizeof(u64);                    \

should be

                v = le64_to_cpu(get_unaligned((__le64 *)*(p)));       \
                *(p) += sizeof(u64);                    \

Endian conversion and unaligned access can be combined, e.g.

		v = get_unaligned_le64(*p);

if p is a pointer to a pointer to an unaligned __le64. These too come via <asm/unaligned.h> and are available since 2.6.26.
--
Stefan Richter
-=====-==--= -==- =-=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux