On Wed, Jul 26, 2023 at 04:06:27PM +0200, Joel Granados wrote: > This is part of the effort to remove the sentinel element from the > ctl_table array at register time. We add a size argument to > __register_sysctl_init and modify the register_sysctl_init macro to > calculate the array size with ARRAY_SIZE. The original callers do not > need to be updated as they will go through the new macro. > > Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx> > --- > fs/proc/proc_sysctl.c | 11 ++--------- > include/linux/sysctl.h | 5 +++-- > 2 files changed, 5 insertions(+), 11 deletions(-) > > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c > index c04293911e7e..6c0721cd35f3 100644 > --- a/fs/proc/proc_sysctl.c > +++ b/fs/proc/proc_sysctl.c > @@ -1444,16 +1444,9 @@ EXPORT_SYMBOL(register_sysctl_sz); > * Context: if your base directory does not exist it will be created for you. > */ > void __init __register_sysctl_init(const char *path, struct ctl_table *table, > - const char *table_name) > + const char *table_name, size_t table_size) Hi Joel, in the same vein as my comment on another patch. Please add table_size to the kernel doc for this function.