On Tue, 25 Jul 2023 14:31:04 -0400, Chuck Lever wrote: > Since offset_iterate_dir() does not walk the parent's d_subdir list > nor does it manipulate the parent's d_child, there doesn't seem to > be a reason to hold the parent's d_lock. The offset_ctx's xarray can > be sufficiently protected with just the RCU read lock. > > Flame graph data captured during the git regression run shows a > 20% reduction in CPU cycles consumed in offset_find_next(). > > [...] I've picked this up. It would be very nice if we could get a perf test from lkp for this fix. --- Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [1/1] libfs: Remove parent dentry locking in offset_iterate_dir() https://git.kernel.org/vfs/vfs/c/01c45fd0472c
