Re: Semantics of fuse_notify_delete()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 26 Jul 2023 at 20:09, Nikolaus Rath <Nikolaus@xxxxxxxx> wrote:
>
> Hello,
>
> It seems to me that fuse_notify_delete
> (https://elixir.bootlin.com/linux/v6.1/source/fs/fuse/dev.c#L1512) fails
> with ENOTEMPTY if there is a pending FORGET request for a directory
> entry within. Is that correct?

It's bug if it does that.

The code related to NOTIFY_DELETE in fuse_reverse_inval_entry() seems
historic.  It's supposed to be careful about mountpoints and
referenced dentries, but d_invalidate() should have already gotten all
that out of the way and left an unhashed dentry without any submounts
or children. The checks just seem redundant, but not harmful.

If you are managing to trigger the ENOTEMPTY case, then something
strange is going on, and we need to investigate.

Thanks,
Miklos



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux