On Wed, Jul 26, 2023 at 06:25:59PM +0800, Hao Xu wrote: > From: Hao Xu <howeyxu@xxxxxxxxxxx> > > Add a nowait parameter for iomap_seek(), later IOMAP_NOWAIT is set > according to this parameter's value. This shows the problem with adding booleans as flags to functions. Now there are -two- anonymous boolean flags to iomap_seek(), and reading the code becomes really hard to know what is actually being asked of iomap_seek(). This is another reason for not combining iomap_seek_data/hole()... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
