On 07/26/23 at 09:03am, Dan Carpenter wrote: > On Wed, Jul 26, 2023 at 01:56:29PM +0800, Baoquan He wrote: > > > > Thanks for this fix. Just curious, this is found out by code exploring, > > or any breaking? > > It's from static analysis, looking at when error codes are type promoted > to unsigned. I pushed the Smatch check for this yesterday. I see, thanks for telling. > > https://github.com/error27/smatch/commit/a2e6ca07e2ef83a72c9ffa3508af1398a6ecc7ed > > regards, > dan carpenter >