On 2023-07-19 23:17:27, Luis Chamberlain wrote: > The filesystem configuration file does not allow you to use symlinks to > devices given the existing sanity checks verify that the target end > device matches the source. > > Using a symlink is desirable if you want to enable persistent tests > across reboots. For example you may want to use /dev/disk/by-id/nvme-eui.* > so to ensure that the same drives are used even after reboot. This > is very useful if you are testing for example with a virtualized > environment and are using PCIe passthrough with other qemu NVMe drives > with one or many NVMe drives. > > To enable support just add a helper to canonicalize devices prior to > running the tests. > > This allows one test runner, kdevops, which I just extended with > support to use real NVMe drives. The drives it uses for the filesystem > configuration optionally is with NVMe eui symlinks so to allow > the same drives to be used over reboots. > > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> > --- Looks good to me: Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx> -- - Andrey