On Thu, Jul 20, 2023 at 01:22:36PM +0200, David Sterba wrote: > On Wed, Jun 28, 2023 at 05:31:22PM +0200, Christoph Hellwig wrote: > > The int used as bool unlock is not a very good way to describe the > > behavior, and the next patch will have to add another beahvior modifier. > > Switch to pass a flag instead, with an inital CFR_KEEP_LOCKED flag that > > specifies the pages should always be kept locked. This is the inverse > > of the old unlock argument for the reason that it requires a flag for > > the exceptional behavior. > > Int is the wrong type but I'm not sure that for two flags we should use > a bit flags. Two bool parameters are IMHO fine and "CFR" does not mean > anything, it's really only relevant for the function. CFR stands for cow_file_range. The good news is that with my (huge) stack of pending pages both flags will eventually go away. The bad news is that for an intermediate change I actually need a third one.
