Hi Hao, kernel test robot noticed the following build warnings: [auto build test WARNING on xfs-linux/for-next] [also build test WARNING on linus/master v6.5-rc2 next-20230718] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hao-Xu/fs-split-off-vfs_getdents-function-of-getdents64-syscall/20230718-212529 base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next patch link: https://lore.kernel.org/r/20230718132112.461218-5-hao.xu%40linux.dev patch subject: [PATCH 4/5] xfs: add NOWAIT semantics for readdir config: x86_64-randconfig-r012-20230718 (https://download.01.org/0day-ci/archive/20230719/202307191021.L6wiZiE6-lkp@xxxxxxxxx/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20230719/202307191021.L6wiZiE6-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202307191021.L6wiZiE6-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> fs/xfs/libxfs/xfs_da_btree.c:2646:8: warning: variable 'buf_flags' set but not used [-Wunused-but-set-variable] int buf_flags = 0; ^ 1 warning generated. vim +/buf_flags +2646 fs/xfs/libxfs/xfs_da_btree.c 2627 2628 /* 2629 * Get a buffer for the dir/attr block, fill in the contents. 2630 */ 2631 int 2632 xfs_da_read_buf( 2633 struct xfs_trans *tp, 2634 struct xfs_inode *dp, 2635 xfs_dablk_t bno, 2636 unsigned int flags, 2637 struct xfs_buf **bpp, 2638 int whichfork, 2639 const struct xfs_buf_ops *ops) 2640 { 2641 struct xfs_mount *mp = dp->i_mount; 2642 struct xfs_buf *bp; 2643 struct xfs_buf_map map, *mapp = ↦ 2644 int nmap = 1; 2645 int error; > 2646 int buf_flags = 0; 2647 2648 *bpp = NULL; 2649 error = xfs_dabuf_map(dp, bno, flags, whichfork, &mapp, &nmap); 2650 if (error || !nmap) 2651 goto out_free; 2652 2653 /* 2654 * NOWAIT semantics mean we don't wait on the buffer lock nor do we 2655 * issue IO for this buffer if it is not already in memory. Caller will 2656 * retry. This will return -EAGAIN if the buffer is in memory and cannot 2657 * be locked, and no buffer and no error if it isn't in memory. We 2658 * translate both of those into a return state of -EAGAIN and *bpp = 2659 * NULL. 2660 */ 2661 if (flags & XFS_DABUF_NOWAIT) 2662 buf_flags |= XBF_TRYLOCK | XBF_INCORE; 2663 error = xfs_trans_read_buf_map(mp, tp, mp->m_ddev_targp, mapp, nmap, 0, 2664 &bp, ops); 2665 if (error) 2666 goto out_free; 2667 if (!bp) { 2668 ASSERT(flags & XFS_DABUF_NOWAIT); 2669 error = -EAGAIN; 2670 goto out_free; 2671 } 2672 2673 if (whichfork == XFS_ATTR_FORK) 2674 xfs_buf_set_ref(bp, XFS_ATTR_BTREE_REF); 2675 else 2676 xfs_buf_set_ref(bp, XFS_DIR_BTREE_REF); 2677 *bpp = bp; 2678 out_free: 2679 if (mapp != &map) 2680 kmem_free(mapp); 2681 2682 return error; 2683 } 2684 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
