On 7/16/23 23:05, Sergey Senozhatsky wrote: > On (23/07/14 10:22), Petr Mladek wrote: >> On Fri 2023-07-14 14:57:59, huzhi001@xxxxxxxxxx wrote: >>> The following checkpatch errors are removed: >>> ERROR: "foo * bar" should be "foo *bar" >>> ERROR: "foo * bar" should be "foo *bar" >>> ERROR: "foo * bar" should be "foo *bar" >>> ERROR: "foo * bar" should be "foo *bar" >> >> Please, do not do fix these cosmetic issues reported by checkpatch.pl. >> It is not worth the effort. In fact, it is contra productive. >> It complicates the git history, backports. > > Absolutely agree with Petr. > > As a side note, I wonder if checkpatch can deprecate that -f option? Either that or document in very strong language that it should only be used in very special circumstances, usually by the file owner or maintainer. -- ~Randy
