Return -EOPNOTSUPP instead of -EINVAL which has the meaning of the argument is an inappropriate value. The current error code doesn't make sense to represent that a file system doesn't support bmap operation. Signed-off-by: Leesoo Ahn <lsahn@xxxxxxxxxxxxxx> --- Changes since v1: - Modify the comments of bmap() - Modify subject and description requested by Markus Elfring https://lore.kernel.org/lkml/20230715060217.1469690-1-lsahn@xxxxxxxxxxxxxx/ fs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 8fefb69e1f84..697c51ed226a 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1831,13 +1831,13 @@ EXPORT_SYMBOL(iput); * 4 in ``*block``, with disk block relative to the disk start that holds that * block of the file. * - * Returns -EINVAL in case of error, 0 otherwise. If mapping falls into a + * Returns -EOPNOTSUPP in case of error, 0 otherwise. If mapping falls into a * hole, returns 0 and ``*block`` is also set to 0. */ int bmap(struct inode *inode, sector_t *block) { if (!inode->i_mapping->a_ops->bmap) - return -EINVAL; + return -EOPNOTSUPP; *block = inode->i_mapping->a_ops->bmap(inode->i_mapping, *block); return 0; -- 2.34.1
