2023-07-15 오후 3:39에 Markus Elfring 이(가) 쓴 글:
> It better returns -EOPNOTSUPP instead of -EINVAL which has meaning of > the argument is an inappropriate value. It doesn't make sense in the > case of that a file system doesn't support bmap operation. > > -EINVAL could make confusion in the userspace perspective. Are imperative change descriptions still preferred? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94 How do you think about to use a subject like “[PATCH v2] fs: inode: Return proper error code in bmap()”? Please reconsider also the distribution of addresses in recipient lists. https://lore.kernel.org/lkml/20230715060217.1469690-1-lsahn@xxxxxxxxxxxxxx/ Regards, Markus
Thank you for the feedback. I will post v2 patch soon best regards, Leesoo
