On Thu, 2023-07-06 at 15:32 +0200, Jan Kara wrote: > On Wed 05-07-23 15:01:21, Jeff Layton wrote: > > In later patches, we're going to change how the inode's ctime field is > > used. Switch to using accessor functions instead of raw accesses of > > inode->i_ctime. > > > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> > > It looks like there are like three commits squashed into this patch - > kernfs, libfs, minix. > > kernfs and libfs parts look good to me - feel free to add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > to them. For the minix part I have one nit: > > > diff --git a/fs/minix/inode.c b/fs/minix/inode.c > > index e9fbb5303a22..3715a3940bd4 100644 > > --- a/fs/minix/inode.c > > +++ b/fs/minix/inode.c > > @@ -501,10 +501,11 @@ static struct inode *V1_minix_iget(struct inode *inode) > > i_gid_write(inode, raw_inode->i_gid); > > set_nlink(inode, raw_inode->i_nlinks); > > inode->i_size = raw_inode->i_size; > > - inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec = raw_inode->i_time; > > + inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode_set_ctime(inode, > > + raw_inode->i_time, > > + 0).tv_sec; > > inode->i_mtime.tv_nsec = 0; > > inode->i_atime.tv_nsec = 0; > > - inode->i_ctime.tv_nsec = 0; > > The usual simplification: > inode->i_mtime = inode->i_atime = inode_set_ctime(inode, > raw_inode->i_time, 0); > > Honza Thanks. I'm not sure what happened with this patch, as some of the subsystems got squashed together. I'll break that up properly too. -- Jeff Layton <jlayton@xxxxxxxxxx>
