Re: [PATCH] exofs: Avoid using file_fsync()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 15, 2009 at 04:31:01PM +0300, Boaz Harrosh wrote:
> +	ret = write_inode_now(inode, 0);

You shouldn't need a write_inode_now, but rather just a similar
sync_inode call as in ext2 or the new simple_fsync as data was
already written by the VFS.

> +	/* This is a good place to write the sb */
> +	/* TODO: Sechedule an sb-sync on create */
> +	sb = inode->i_sb;
> +	lock_super(sb);
> +	if (sb->s_dirt && sb->s_op->write_super)
> +		sb->s_op->write_super(sb);
> +	unlock_super(sb);

fsync is not a really good place for a sb write normally.  What metadata
in the superblock is needed related to syncing a single file in btrfs?

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux