Re: [PATCH v2 44/92] fat: convert to ctime accessor functions

[OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>]

Jeff Layton <jlayton@xxxxxxxxxx> writes:

> @@ -1407,8 +1407,9 @@ static int fat_read_root(struct inode *inode)
>  	MSDOS_I(inode)->mmu_private = inode->i_size;
>  
>  	fat_save_attrs(inode, ATTR_DIR);
> -	inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec = 0;
> -	inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = 0;
> +	inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode_set_ctime(inode,
> +									0, 0).tv_sec;
> +	inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = 0;

Maybe, this should simply be

	inode->i_mtime = inode->i_atime = inode_set_ctime(inode, 0, 0);

?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>