On Mon, Jun 15, 2009 at 08:44:47AM +0200, Nick Piggin wrote: > Did we verify with filesystem maintainers (eg. btrfs) that the > !ISREG test will be enough to prevent oopses? BTW. this is quite a significant change I think and not really documented well enough. Previously a filesystem will know exactly when and why pagecache in a mapping under its control will be truncated (as opposed to invalidated). They even have opportunity to hold locks such as i_mutex. And depending on what they do, they could do interesting things even with ISREG files. So, I really think this needs review by filesystem maintainers and it would be far safer to use invalidate until it is known to be safe. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
