Sam Ravnborg wrote: >> + >> +config PRAMFS_NOWP >> + bool "Disable PRAMFS write protection" >> + depends on PRAMFS >> + default n >> + help >> + Say Y here to disable the write protect feature of PRAMFS. > n is default so "default n" is not needed. > If you reverse the logic (and add a default y) then.. > >> +ifneq ($(CONFIG_PRAMFS_NOWP),y) >> +pramfs-objs += wprotect.o >> +endif > This is a trivial: > pramfs-$(PRAMFS_WRITE_PROTECT) += wprotect.o > > (I renamed the option to something more descriptive - please do so in the abvoe). > > >> +++ linux-2.6.30/fs/pramfs/Makefile 2009-04-19 11:58:51.000000000 +0200 >> @@ -0,0 +1,13 @@ >> +# >> +# Makefile for the linux pram-filesystem routines. >> +# >> + >> +obj-$(CONFIG_PRAMFS) += pramfs.o >> +obj-$(CONFIG_TEST_MODULE) += pramfs_test.o >> + >> +pramfs-objs := balloc.o dir.o file.o inode.o namei.o super.o symlink.o > > Use: > pramfs-y := balloc.o ... > > This match usa later in this file. > >> + >> +ifneq ($(CONFIG_PRAMFS_NOWP),y) >> +pramfs-objs += wprotect.o >> +endif >> +pramfs-$(CONFIG_PRAMFS_XIP) += xip.o > > > Sam > Ok, thanks. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
