Re: [PATCH 10/23] btrfs: reduce the number of arguments to btrfs_run_delalloc_range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Chris Mason <clm@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>
Subject: Re: [PATCH 10/23] btrfs: reduce the number of arguments to btrfs_run_delalloc_range
From: Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx>
Date: Tue, 4 Jul 2023 09:00:13 +0000
Accept-language: en-US
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <20230628153144.22834-11-hch@lst.de>
Thread-index: AQHZqdY8RZ6M/FDozUq+oEDy0wdrvK+pWDUA
Thread-topic: [PATCH 10/23] btrfs: reduce the number of arguments to btrfs_run_delalloc_range
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0
Wdcipoutbound: EOP-TRUE

On 28.06.23 17:35, Christoph Hellwig wrote:
> btrfs_run_delalloc_range already started writeback by itself, overload
> the return value with a positive 1 in additio to 0 and a negative error                               addition ~^

For the rest of the patch, I don't feel competent enough, I'm sorry

References:
- btrfs compressed writeback cleanups
  - From: Christoph Hellwig
- [PATCH 10/23] btrfs: reduce the number of arguments to btrfs_run_delalloc_range
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 08/23] btrfs: remove the return value from extent_write_locked_range
Next by Date: Re: [PATCH 11/23] btrfs: clean up the check for uncompressed ranges in submit_one_async_extent
Previous by thread: [PATCH 10/23] btrfs: reduce the number of arguments to btrfs_run_delalloc_range
Next by thread: [PATCH 13/23] btrfs: merge async_cow_start and compress_file_range
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]