Hi Shiyang, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Shiyang-Ruan/xfs-fix-the-calculation-for-end-and-length/20230629-161913 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230629081651.253626-3-ruansy.fnst%40fujitsu.com patch subject: [PATCH v12 2/2] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind config: x86_64-kexec (https://download.01.org/0day-ci/archive/20230629/202306291954.zqVvCUZ5-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230629/202306291954.zqVvCUZ5-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202306291954.zqVvCUZ5-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): fs/xfs/xfs_notify_failure.c: In function 'xfs_dax_notify_failure_freeze': >> fs/xfs/xfs_notify_failure.c:127:33: error: 'FREEZE_HOLDER_KERNEL' undeclared (first use in this function) 127 | while (freeze_super(sb, FREEZE_HOLDER_KERNEL) != 0) { | ^~~~~~~~~~~~~~~~~~~~ fs/xfs/xfs_notify_failure.c:127:33: note: each undeclared identifier is reported only once for each function it appears in >> fs/xfs/xfs_notify_failure.c:127:16: error: too many arguments to function 'freeze_super' 127 | while (freeze_super(sb, FREEZE_HOLDER_KERNEL) != 0) { | ^~~~~~~~~~~~ In file included from include/linux/huge_mm.h:8, from include/linux/mm.h:988, from fs/xfs/kmem.h:11, from fs/xfs/xfs_linux.h:24, from fs/xfs/xfs.h:22, from fs/xfs/xfs_notify_failure.c:6: include/linux/fs.h:2289:12: note: declared here 2289 | extern int freeze_super(struct super_block *super); | ^~~~~~~~~~~~ fs/xfs/xfs_notify_failure.c: In function 'xfs_dax_notify_failure_thaw': fs/xfs/xfs_notify_failure.c:140:32: error: 'FREEZE_HOLDER_KERNEL' undeclared (first use in this function) 140 | error = thaw_super(sb, FREEZE_HOLDER_KERNEL); | ^~~~~~~~~~~~~~~~~~~~ >> fs/xfs/xfs_notify_failure.c:140:17: error: too many arguments to function 'thaw_super' 140 | error = thaw_super(sb, FREEZE_HOLDER_KERNEL); | ^~~~~~~~~~ include/linux/fs.h:2290:12: note: declared here 2290 | extern int thaw_super(struct super_block *super); | ^~~~~~~~~~ >> fs/xfs/xfs_notify_failure.c:148:24: error: 'FREEZE_HOLDER_USERSPACE' undeclared (first use in this function) 148 | thaw_super(sb, FREEZE_HOLDER_USERSPACE); | ^~~~~~~~~~~~~~~~~~~~~~~ fs/xfs/xfs_notify_failure.c:148:9: error: too many arguments to function 'thaw_super' 148 | thaw_super(sb, FREEZE_HOLDER_USERSPACE); | ^~~~~~~~~~ include/linux/fs.h:2290:12: note: declared here 2290 | extern int thaw_super(struct super_block *super); | ^~~~~~~~~~ vim +/FREEZE_HOLDER_KERNEL +127 fs/xfs/xfs_notify_failure.c 119 120 static void 121 xfs_dax_notify_failure_freeze( 122 struct xfs_mount *mp) 123 { 124 struct super_block *sb = mp->m_super; 125 126 /* Wait until no one is holding the FREEZE_HOLDER_KERNEL. */ > 127 while (freeze_super(sb, FREEZE_HOLDER_KERNEL) != 0) { 128 // Shall we just wait, or print warning then return -EBUSY? 129 delay(HZ / 10); 130 } 131 } 132 133 static void 134 xfs_dax_notify_failure_thaw( 135 struct xfs_mount *mp) 136 { 137 struct super_block *sb = mp->m_super; 138 int error; 139 > 140 error = thaw_super(sb, FREEZE_HOLDER_KERNEL); 141 if (error) 142 xfs_emerg(mp, "still frozen after notify failure, err=%d", 143 error); 144 /* 145 * Also thaw userspace call anyway because the device is about to be 146 * removed immediately. 147 */ > 148 thaw_super(sb, FREEZE_HOLDER_USERSPACE); 149 } 150 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
