On Tue, Jun 27, 2023 at 11:50 PM Ahelenia Ziemiańska
<nabijaczleweli@xxxxxxxxxxxxxxxxxx> wrote:
>
> Always generate modify out, access in for splice;
> this gets automatically merged with no ugly special cases.
Ahelenia,
Obviously, you are new to sending patches to the kernel
and you appear to be a very enthusiastic and fast learner,
so I assume you won't mind getting some tips that you won't
find in any document.
a) CC LTP only on tests, not on the kernel patches
b) Please don't post these "diff" patches.
Developers (and bots) should be able to understand which
upstream commit a patch is based on (git format-patch provides that info).
I mean you can send those diff patches as part of a conversation to
explain yourself, that's fine, just don't post them as if they are patches
for review.
c) When there are prospect reviewers that have not reviewed v1
(especially inotify maintainer), it is better to wait at least one day posting
v2 and v3 and v4 ;), because:
1. It is better to accumulate review comments from several reviewers
2. Different reviewers may disagree, so if you are just following my
advice you may need to go back and forth until everyone is happy
3. It's racy - reviewers may be in the middle of review of v1 without
realizing that v2,v3,v4 is already in their inbox, so that's creating
extra work for them - not a good outcome
Going to review v4....
Thanks,
Amir.
