> + if (folio_test_writeback(folio)) {
> + if (wbc->sync_mode != WB_SYNC_NONE)
> + folio_wait_writeback(folio);
> + else
> + return false;
> + }
Please reorder this to avoid the else and return earlier while you're
at it:
if (folio_test_writeback(folio)) {
if (wbc->sync_mode == WB_SYNC_NONE)
return false;
folio_wait_writeback(folio);
}
(that's what actually got me started on my little cleanup spree while
checking some details of the writeback waiting..)
> + BUG_ON(folio_test_writeback(folio));
> + if (!folio_clear_dirty_for_io(folio))
> + return false;
> +
> + return true;
..
return folio_clear_dirty_for_io(folio);
?
