Now that all filesystems provide ->sync_fs methods we can change __sync_filesystem to only call ->sync_fs. This gives us a clear separation between periodic writeouts which are driven by ->write_super and data integrity syncs that go through ->sync_fs. (modulo file_fsync which is also going away) Signed-off-by: Christoph Hellwig <hch@xxxxxx> Index: vfs-2.6/fs/sync.c =================================================================== --- vfs-2.6.orig/fs/sync.c 2009-06-05 16:29:58.691814461 +0200 +++ vfs-2.6/fs/sync.c 2009-06-05 16:31:13.702939647 +0200 @@ -33,8 +33,6 @@ static int __sync_filesystem(struct supe else sync_quota_sb(sb, -1); sync_inodes_sb(sb, wait); - if (sb->s_dirt && sb->s_op->write_super) - sb->s_op->write_super(sb); if (sb->s_op->sync_fs) sb->s_op->sync_fs(sb, wait); return __sync_blockdev(sb->s_bdev, wait); -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html