On Thu, Jun 15, 2023 at 06:51:35PM +1000, Dave Chinner wrote: > On Thu, Jun 15, 2023 at 08:21:10AM +0200, Hannes Reinecke wrote: > > On 6/15/23 01:53, Dave Chinner wrote: > > > On Wed, Jun 14, 2023 at 05:06:14PM +0200, Hannes Reinecke wrote: > > > All you need to do now is run the BS > PS filesytems through a full > > > fstests pass (reflink + rmap enabled, auto group), and then we can > > > start on the real data integrity validation work. It'll need tens of > > > billions of fsx ops run on it, days of recoveryloop testing, days of > > > fstress based exercise, etc before we can actually enable it in > > > XFS.... > > > > > Hey, c'mon. I do know _that_. All I'm saying is that now we can _start_ > > running tests and figure out corner cases (like NFS crashing on me :-). > > With this patchset we now have some infrastructure in place making it > > even _possible_ to run those tests. > > I got to this same point several years ago. You know, that patchset > that Luis went back to when he brought up this whole topic again? > That's right when I started running fsx, and I realised it > didn't cover FICLONERANGE, FIDEDUPERANGE and copy_file_range(). > > Yep, that's when we first realised we had -zero- test coverage of > those operations. Darrick and I spent the next *3 months* pretty > much rewriting the VFS level of those operations and fixing all the > other bugs in the implementations, just so we could validate they > worked correct on BS <= PS. code coverage analysis...
