On Sun, Jun 11, 2023 at 09:45:45PM -0700, Christoph Hellwig wrote: > On Sun, Jun 11, 2023 at 10:47:05PM +0300, Amir Goldstein wrote: > > Overlayfs and cachefiles use open_with_fake_path() to allocate internal > > files, where overlayfs also puts a "fake" path in f_path - a path which > > is not on the same fs as f_inode. > > But cachefs doesn't, so this needs a better explanation / documentation. > > > Allocate a container struct file_fake for those internal files, that > > is used to hold the fake path along with an optional real path. > > The idea looks sensible, but fake a is a really weird term here. > I know open_with_fake_path also uses it, but we really need to > come up with a better name, and also good documentation of the > concept here. It's basically a stack so I'd either use struct file_stack or struct file_proxy; with a preference for the latter.
