On Sat, Jun 10, 2023 at 05:09:05PM +0530, Ritesh Harjani (IBM) wrote: > This patch factors iomap_write_delalloc_punch() function out. This function > is resposible for actual punch out operation. > The reason for doing this is, to avoid deep indentation when we bring punch-out > of individual non-dirty blocks within a dirty folio in a later patch > (which adds per-block dirty status handling to iomap) to avoid delalloc block > leak. A bunch of overly long lines in the commit message here, but otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>