On Thu, Jun 04, 2009 at 02:30:33PM -0700, Matt Helsley wrote: > On Thu, Jun 04, 2009 at 08:07:23AM -0700, Linus Torvalds wrote: > > On Thu, 4 Jun 2009, Matt Helsley wrote: > > > > > > Doesn't this pin the vfs mount of the executable for the lifetime of > > > the task? > > > > Well, yes, but so does the current code. > > Not quite. The current code pins it as long as the corresponding VMAs > are mapped -- not for the lifetime of the task. > > > Sure, in _theory_ it can be a non-mmap executable (maybe people still have > > those old OMAGIC a.out executables), and in _theory_ you could unmap the > > executable even if it was originally mmap'ed, but neither of those is > > exactly common, are they? > > Not common to my knowledge, no. > > > > > So in practice, nothing has changed wrt lifetime of the executable. > > Almost all of the time, yes. And year ago executable wasn't pinned at all, so if you're opposing widening of time executable is pinned, you should revert your own patch which introduced it in first place. ->exec_path merely makes /proc/*/exe very unheuristical (binfmt loader decides, nothing else) and suitable for other code as demonstrated. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
