On Wed, Jun 07, 2023 at 10:05:46PM -0700, Christoph Hellwig wrote: > On Sun, May 07, 2023 at 06:17:13PM -0700, Luis Chamberlain wrote: > > Provide helpers so that we can check a superblock frozen state. > > This will make subsequent changes easier to read. This makes > > no functional changes. > > I'll look at the further changes, but having frozen/unfrozen helpers > that sound binary while we have 4 shades of gray seems rather confusing > to me. That was my first reaction too. Then it occurred to me that *some* people might still be clued into that subtlety if they happened to ask themselves why there are predicates for _is_frozen and _is_unfrozen. But in the end I think I decided that an enum isn't subtle like that at all and clearly forgot to reply with that. --D
