Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool
From: Hannes Reinecke <hare@xxxxxxx>
Date: Wed, 7 Jun 2023 15:02:11 +0200
Cc: Richard Weinberger <richard@xxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Chris Mason <clm@xxxxxx>, David Sterba <dsterba@xxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>, dm-devel@xxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx
In-reply-to: <20230606073950.225178-20-hch@lst.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/6/23 09:39, Christoph Hellwig wrote:

Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
  drivers/scsi/scsi_bsg.c   | 2 +-
  drivers/scsi/scsi_ioctl.c | 8 ++++----
  drivers/scsi/sg.c         | 2 +-
  include/scsi/scsi_ioctl.h | 2 +-
  4 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes

References:
- decouple block open flags from fmode_t
  - From: Christoph Hellwig
- [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 18/31] fs: remove sb->s_mode
Next by Date: Re: [PATCH 20/31] scsi: replace the fmode_t argument to scsi_ioctl with a simple bool
Previous by thread: Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool
Next by thread: Re: [PATCH 19/31] scsi: replace the fmode_t argument to scsi_cmd_allowed with a simple bool
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]