On Thu, 01 Jun 2023 12:58:20 +0200, Jan Kara wrote: > this patch set fixes a problem with cross directory renames originally reported > in [1]. To quickly sum it up some filesystems (so far we know at least about > ext4, udf, f2fs, ocfs2, likely also reiserfs, gfs2 and others) need to lock the > directory when it is being renamed into another directory. This is because we > need to update the parent pointer in the directory in that case and if that > races with other operation on the directory (in particular a conversion from > one directory format into another), bad things can happen. > > [...] I've picked this up to get it into -next. I've folded the following fix for the missing { into [4/6]. --- Applied to the vfs.rename.locking branch of the vfs/vfs.git tree. Patches in the vfs.rename.locking branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.rename.locking [1/6] ext4: Remove ext4 locking of moved directory https://git.kernel.org/vfs/vfs/c/3658840cd363 [2/6] Revert "udf: Protect rename against modification of moved directory" https://git.kernel.org/vfs/vfs/c/7517ce5dc4d6 [3/6] Revert "f2fs: fix potential corruption when moving a directory" https://git.kernel.org/vfs/vfs/c/cde3c9d7e2a3 [4/6] fs: Establish locking order for unrelated directories https://git.kernel.org/vfs/vfs/c/f23ce7571853 [5/6] fs: Lock moved directories https://git.kernel.org/vfs/vfs/c/28eceeda130f [6/6] fs: Restrict lock_two_nondirectories() to non-directory inodes https://git.kernel.org/vfs/vfs/c/afb4adc7c3ef