On Thu 25-05-23 12:48:33, Amir Goldstein wrote: > On Thu, May 25, 2023 at 12:26 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > > > On Wed, May 24, 2023 at 04:06:48PM +0200, Jan Kara wrote: > > > Yes, I've checked and all ->encode_fh() implementations return > > > FILEID_INVALID in case of problems (which are basically always only > > > problems with not enough space in the handle buffer). > > > > ceph_encode_fh() can return -EINVAL > > Ouch! thanks for pointing this out > > Jeff, > > In your own backyard ;-) > Do you think this new information calls for rebasing my fix on top of master > and marking it for stable? or is this still low risk in your opinion? OK, since I don't see a strong push for merging this ASAP, I'm keeping the fix in my fsnotify branch and will push it to Linus during the merge window. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
