On Tue, May 30, 2023 at 7:29 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote: > > The security keys sysctls are already declared on its own file, > just move the sysctl registration to its own file to help avoid > merge conflicts on sysctls.c, and help with clearing up sysctl.c > further. > > This creates a small penalty of 23 bytes: > > ./scripts/bloat-o-meter vmlinux.1 vmlinux.2 > add/remove: 2/0 grow/shrink: 0/1 up/down: 49/-26 (23) > Function old new delta > init_security_keys_sysctls - 33 +33 > __pfx_init_security_keys_sysctls - 16 +16 > sysctl_init_bases 85 59 -26 > Total: Before=21256937, After=21256960, chg +0.00% > > But soon we'll be saving tons of bytes anyway, as we modify the > sysctl registrations to use ARRAY_SIZE and so we get rid of all the > empty array elements so let's just clean this up now. > > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> > --- > include/linux/key.h | 3 --- > kernel/sysctl.c | 4 ---- > security/keys/sysctl.c | 7 +++++++ > 3 files changed, 7 insertions(+), 7 deletions(-) Ultimately I'll leave the ACK to David or Jarkko, but this looks reasonable to me. Reviewed-by: Paul Moore <paul@xxxxxxxxxxxxxx> -- paul-moore.com
