Re: [PATCH] fs: Drop wait_unfrozen wait queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 25-05-23 20:16:04, Christian Brauner wrote:
> On Thu, May 25, 2023 at 04:17:10PM +0200, Jan Kara wrote:
> > wait_unfrozen waitqueue is used only in quota code to wait for
> > filesystem to become unfrozen. In that place we can just use
> > sb_start_write() - sb_end_write() pair to achieve the same. So just
> > remove the waitqueue.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > ---
> 
> Removing code. I'm all here for it...
> Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
> 
> >  fs/quota/quota.c   | 5 +++--
> >  fs/super.c         | 4 ----
> >  include/linux/fs.h | 1 -
> >  3 files changed, 3 insertions(+), 7 deletions(-)
> > 
> > Guys, I can merge this cleanup through my tree since I don't expect any
> > conflicts and the generic part is pure removal of unused code.
> 
> There'll likely be another set of fixes I'll take next week but I
> honestly don't care. But seems that this isn't really urgent so why not
> just wait for the merge window?

Sure, I'll queue the patch for the next merge window. Thanks for review!

								Honza

-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux