Re: Extending page pinning into fs/direct-io.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: Extending page pinning into fs/direct-io.c
From: David Howells <dhowells@xxxxxxxxxx>
Date: Thu, 25 May 2023 18:07:23 +0100
Cc: dhowells@xxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <e00ee9f5-0f02-6463-bc84-b94c17f488bc@redhat.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

David Hildenbrand <david@xxxxxxxxxx> wrote:

> I think the correct way to test for a zero page is
> is_zero_pfn(page_to_pfn(page).
> 
> Using my_zero_pfn(vmf->address) in do_anonymous_page() these can easily end up
> in any process.

Should everywhere that is using ZERO_PAGE(0) actually be using my_zero_pfn()?

ZERO_PAGE() could do with a kdoc comment saying how to use it.

David

Follow-Ups:
- Re: Extending page pinning into fs/direct-io.c
  - From: Linus Torvalds

References:
- Re: Extending page pinning into fs/direct-io.c
  - From: David Hildenbrand
- Re: [PATCH v21 0/6] block: Use page pinning
  - From: Christoph Hellwig
- [PATCH v21 0/6] block: Use page pinning
  - From: David Howells
- Extending page pinning into fs/direct-io.c
  - From: David Howells
- Re: Extending page pinning into fs/direct-io.c
  - From: Christoph Hellwig
- Re: Extending page pinning into fs/direct-io.c
  - From: David Howells
- Re: Extending page pinning into fs/direct-io.c
  - From: Linus Torvalds

Prev by Date: Re: Extending page pinning into fs/direct-io.c
Next by Date: Re: Extending page pinning into fs/direct-io.c
Previous by thread: Re: Extending page pinning into fs/direct-io.c
Next by thread: Re: Extending page pinning into fs/direct-io.c
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]