On Wed 24-05-23 13:36:11, Jeff Layton wrote: > On Wed, 2023-05-24 at 20:24 +0300, Amir Goldstein wrote: > > On Wed, May 24, 2023 at 8:05 PM Jeff Layton <jlayton@xxxxxxxxxx> wrote: ... > > > > Beyond the general idea, do you also ACK my fix to _fh_update() > > above? I wasn't 100% sure about it. > > > > That looks like the right way to handle _fh_update(). I think that > should also make it also treat a value of 0 as an error, which seems > like the right thing to do (even of no caller tries to do that today). > > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> Thanks! I've added the patch into my tree. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
