On Tue, May 23, 2023 at 02:46:07PM +0200, Andreas Gruenbacher wrote: > > void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio, > > - unsigned int from, unsigned int len) > > + size_t from, size_t len) > > { > > struct buffer_head *head = folio_buffers(folio); > > unsigned int bsize = head->b_size; > > This only makes sense if the to, start, and end variables in > gfs2_trans_add_databufs() are changed from unsigned int to size_t as > well. The history of this patch is that I started doing conversions from page -> folio in gfs2, then you came out with a very similar series. This patch is the remainder after rebasing my patches on yours. So we can either drop this patch or just apply it. I wasn't making a concerted effort to make gfs2 support 4GB+ sized folios, it's just part of the conversion that I do. > > extern void gfs2_trans_add_databufs(struct gfs2_inode *ip, struct folio *folio, > > - unsigned int from, unsigned int len); > > + size_t from, size_t len);