Re: [PATCH] cifs: Fix cifs_limit_bvec_subset() to correctly check the maxmimum size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 22, 2023 at 1:11 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Shyam Prasad N <nspmangalore@xxxxxxxxx> wrote:
>
> > > +               max_size -= len;
> >
> > Shouldn't this decrement happen below, after the span has been
> > compared with max_size?
>
> It probably doesn't matter.  The compiler is free to move it around, but yes
> that and ix++ can both be moved down.

I am not sure I follow - can you explain? It looks like moving it up
vs. down would change behavior


-- 
Thanks,

Steve




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux