Re: [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Howells <dhowells@xxxxxxxxxx>
Subject: Re: [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 19 May 2023 01:10:16 -0700
Cc: Jens Axboe <axboe@xxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Hillf Danton <hdanton@xxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, linux-erofs@xxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20230519074047.1739879-6-dhowells@redhat.com>

On Fri, May 19, 2023 at 08:40:20AM +0100, David Howells wrote:
> +#ifdef CONFIG_FS_DAX
> +	if (IS_DAX(in->f_mapping->host))

No need for the ifdef.  IS_DAX is compile-time false if CONFIG_FS_DAX
is not set.

A comment on why we're doing this in the code would probably be useful
as well.

References:
- [PATCH v20 00/32] splice, block: Use page pinning and kill ITER_PIPE
  - From: David Howells
- [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read()
  - From: David Howells

Prev by Date: Re: [PATCH v20 03/32] splice: Make direct_read_splice() limit to eof where appropriate
Next by Date: Re: [PATCH v20 09/32] tty, proc, kernfs, random: Use direct_splice_read()
Previous by thread: [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read()
Next by thread: Re: [PATCH v20 05/32] splice: Make splice from a DAX file use direct_splice_read()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [NTFS 3] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [NTFS 3] [Samba] [Device Mapper] [CEPH Development]