On Fri, May 12, 2023 at 12:26 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > Much simpler to drop the cast in __pte_page() instead: > > @@ -91,7 +91,7 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) > #define pmd_set(pmdp,ptep) do {} while (0) > > #define __pte_page(pte) \ > -((unsigned long) __va ((pte_val (pte) & SUN3_PAGE_PGNUM_MASK) << PAGE_SHIFT)) > + (__va ((pte_val (pte) & SUN3_PAGE_PGNUM_MASK) << PAGE_SHIFT)) Thanks, folded this into the patch! Yours, Linus Walleij