On Thu, May 04, 2023 at 08:34:27PM +0900, Tetsuo Handa wrote:
> On 2023/05/04 20:14, Dan Carpenter wrote:
> > Hello Tetsuo Handa,
> >
> > The patch 81b21c0f0138: "fs: hfsplus: remove WARN_ON() from
> > hfsplus_cat_{read,write}_inode()" from Apr 11, 2023, leads to the
> > following Smatch static checker warning:
> >
> > fs/hfsplus/inode.c:596 hfsplus_cat_write_inode()
> > warn: missing error code here? 'hfsplus_find_cat()' failed. 'res' = '0'
>
> It has been returning 0 since commit 1da177e4c3f4 ("Linux-2.6.12-rc2").
> I guess that the author of this filesystem was wondering what to do in that case.
> Since this filesystem is orphaned, I don't know whom to ask.
> If you think returning an error is better, please submit as a patch.
Returning an error is probably correct, but I can't test it. Let's just
leave the warning until someone comes who knows for sure.
regards,
dan carpenter
