Re: [PATCH RFC 16/16] nvme: Support atomic writes

To: John Garry <john.g.garry@xxxxxxxxxx>, axboe@xxxxxxxxx, kbusch@xxxxxxxxxx, hch@xxxxxx, sagi@xxxxxxxxxxx, martin.petersen@xxxxxxxxxx, djwong@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, dchinner@xxxxxxxxxx, jejb@xxxxxxxxxxxxx
Subject: Re: [PATCH RFC 16/16] nvme: Support atomic writes
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 3 May 2023 11:49:56 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, paul@xxxxxxxxxxxxxx, jmorris@xxxxxxxxx, serge@xxxxxxxxxx, Alan Adamson <alan.adamson@xxxxxxxxxx>
In-reply-to: <20230503183821.1473305-17-john.g.garry@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 5/3/23 11:38, John Garry wrote:

+			if (!(boundary & (boundary - 1))) {


Please use is_power_of_2() instead of open-coding it.

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH RFC 16/16] nvme: Support atomic writes
  - From: John Garry

References:
- [PATCH RFC 00/16] block atomic writes
  - From: John Garry
- [PATCH RFC 16/16] nvme: Support atomic writes
  - From: John Garry